Enhance feedback interaction by adding keyboard accessibility for thumbs up/down buttons #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbs up/down buttons
priyanshu92
approved these changes
Dec 19, 2024
sanxsth
approved these changes
Dec 19, 2024
amitjoshi438
deleted the
users/amitjoshi/proDevCopilotFeedbackAccessibilityFix
branch
sanxsth
added a commit
that referenced
this pull request
Feb 3, 2025
* Refactor PowerPagesChatParticipant and add CommandRegistry (#1050) Co-authored-by: amitjoshi <[email protected]> * [PowerPage][Copilot] Nl2Site and Nl2Page Service Integration for Site Create (#1053) * Refactor PowerPagesChatParticipantConstants and add NL2PAGE and NL2SITE constants * Refactor PowerPagesChatParticipantConstants and add new page types * Update constants and move telemetry to different file * Refactor and add getCommonHeaders function --------- Co-authored-by: amitjoshi <[email protected]> * Corrected scope of PPAPI access token for preprod env (#1055) Co-authored-by: Ashwani Kumar <[email protected]> * Hook for create site command with nl2page&site (#1057) * Hook for create site command with nl2page&site * Disable any type validation * Refactor PowerPagesChatParticipantConstants and CreateSiteCommand - Add NL2SITE_GENERATING_SITE constant for generating a new Power Pages site - Update progress message in CreateSiteCommand to use NL2SITE_GENERATING_SITE constant - Remove unnecessary markdown formatting in CreateSiteHelper error handling * Refactor localization files and update Power Pages chat participant utils * Refactor NL2SiteService and Nl2PageService to include additional telemetry logging --------- Co-authored-by: amitjoshi <[email protected]> Co-authored-by: tyaginidhi <[email protected]> * Add environment list retrieval and refactor BAP endpoint logic (#1060) * Add environment list retrieval and refactor BAP endpoint logic * Add type annotation for environment list retrieval in Utils.ts * Update src/common/utilities/Utils.ts Co-authored-by: Priyanshu Agrawal <[email protected]> * Refactor BAP environment list URL to use a variable for API version and update imports in Utils.ts --------- Co-authored-by: amitjoshi <[email protected]> Co-authored-by: Priyanshu Agrawal <[email protected]> * [PowerPages][create-site] Preview and Edit Site Page and Command Registration (#1061) * Enhance CreateSiteCommand to include extension context and add ReadonlyFileSystemProvider for site page previews * Implement EditableFileSystemProvider for site page editing and update CreateSiteHelper to utilize it * Integrate CreateSiteCommand into CommandRegistry and update related components for site creation functionality * Disable copy functionality in EditableFileSystemProvider implementation * Remove ReadonlyFileSystemProvider implementation * Add telemetry constant for previewing site pages and refactor related components * Refactor CommandRegistry and add command registration utility for chat participants * Add constants for site creation parameters and refactor NL2SiteService to use them * Refactor CreateSiteCommand and CreateSiteHelper to use structured options and improve readability; add CreateSiteTypes for better type management * Add error telemetry constant for previewing site pages and handle errors in previewSitePagesContent function * Rename fileContentMap to _fileContentMap for consistency and clarity in EditableFileSystemProvider * Remove unused getUpdatedPageContent function from CreateSiteHelper to streamline code * Add ESLint disable comments for any type usage in CreateSiteHelper and CreateSiteTypes --------- Co-authored-by: amitjoshi <[email protected]> * Bump cross-spawn (#1059) Bumps and [cross-spawn](https://github.com/moxystudio/node-cross-spawn). These dependencies needed to be updated together. Updates `cross-spawn` from 7.0.3 to 7.0.6 - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) Updates `cross-spawn` from 6.0.5 to 7.0.6 - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump CLI version from 1.35.1 to 1.37.4 (#1065) Co-authored-by: amitjoshi <[email protected]> * December Release Notes (#1066) * add release note * fix typo --------- Co-authored-by: Sandeep Satheesh <[email protected]> * Remove unused command from package.json (#1070) Removing the command `extension.createChatView` from package.json as it is registered but there is no handler associated with it. * Fix error type for concurrency handler (#1071) Fixes the error throws in case of bulk header rejection * Add code coverage output folder in gitignore (#1072) Adding the code coverage output folder `.nyc_ouput` folder in `.gitignore` so that it doesn't show up in `git diff` after running code coverage command. * Refactor CLI Acquisition Context (#1074) * Refactor CLI Acquisition Context * Fix import * Add tests * [PowerPages] [Create-Site] Implement multi-step site creation with enhanced input handling (#1063) * Enhance CreateSiteCommand to include extension context and add ReadonlyFileSystemProvider for site page previews * Implement EditableFileSystemProvider for site page editing and update CreateSiteHelper to utilize it * Integrate CreateSiteCommand into CommandRegistry and update related components for site creation functionality * Disable copy functionality in EditableFileSystemProvider implementation * Remove ReadonlyFileSystemProvider implementation * Add telemetry constant for previewing site pages and refactor related components * Refactor CommandRegistry and add command registration utility for chat participants * Add constants for site creation parameters and refactor NL2SiteService to use them * Refactor CreateSiteCommand and CreateSiteHelper to use structured options and improve readability; add CreateSiteTypes for better type management * Add error telemetry constant for previewing site pages and handle errors in previewSitePagesContent function * Rename fileContentMap to _fileContentMap for consistency and clarity in EditableFileSystemProvider * Implement multi-step input for site creation and register command for user inputs in CreateSiteHelper * Enhance copilot availability checks and update response structure in ArtemisService * Add site creation inputs and environment info interfaces; refactor CreateSiteCommand * Update src/common/chat-participants/powerpages/commands/create-site/CreateSiteTypes.ts Co-authored-by: Priyanshu Agrawal <[email protected]> * Update src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts Co-authored-by: Priyanshu Agrawal <[email protected]> * Update src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts Co-authored-by: Priyanshu Agrawal <[email protected]> * Add eslint directives to suppress no-explicit-any warnings in site page handling --------- Co-authored-by: amitjoshi <[email protected]> Co-authored-by: Priyanshu Agrawal <[email protected]> * Fix accessibility issue in Pages Copilot pane (#1076) Fix accessibility issue in `Send` button in Power Pages Copilot pane. Updated the `aria-label` to `Send` instead of `Match Case` * Fix casing of OrgUrl to orgUrl in site creation input handling (#1077) Co-authored-by: amitjoshi <[email protected]> * Add test scripts in .vscode\tasks.json (#1078) To be able to easily run tests from VS Code, added test scripts in `tasks.json` * Remove redundant step from gulp file (#1079) The step `testWeb` is redundant as the step `testUnitTests` already includes the test pattern defined in `testWeb` step. Hence, removing it from gulp config. * Added site runtime preview code behind ECS Config (#1052) * Added site runtime preview code behind ECS Config * localization added and moved preview site code to separate file * fixed build failures and handled empty website recordID * Corrected website details ppapi service for runtime preview * merged main branch to runtimePreviewECS * correcting function call for runtime preview * corrected localised error * removed bug of no show command found * Launch Edge new tab instead of launching project --------- Co-authored-by: Ashwani Kumar <[email protected]> Co-authored-by: Priyanshu Agrawal <[email protected]> * Hide preview site command from palette when feature is disabled (#1080) * Enhance feedback interaction by adding keyboard accessibility for thumbs up/down buttons (#1082) Co-authored-by: amitjoshi <[email protected]> * Add conditional visibility for Current Active Users command in web virtual workspace and remove alt cmds (#1083) Co-authored-by: amitjoshi <[email protected]> * Handle null language code for content snippets and update query parameters in portal schema (#1086) Co-authored-by: amitjoshi <[email protected]> * Enhance accessibility by adding ARIA attributes and keyboard navigation support (#1085) Co-authored-by: amitjoshi <[email protected]> * Enhance accessibility by adding ARIA attributes and making thinking message focusable (#1087) Co-authored-by: amitjoshi <[email protected]> * Add sovereign cloud endpoints for PPAPI service (#1081) * Site Preview Enhancements: Clear cache and telemetry logging (#1088) * Enhance accessibility by improving focus styles and adding ARIA attributes in notification panel (#1089) Co-authored-by: amitjoshi <[email protected]> * Actions Hub: Implement base classes to show tree structure (#1090) * Add models for Actions Hub * Basic wireup * Add models * ToDo * Remove foo environment * Remove error * Refactor * Add translations * Add tests * Add tree item for No sites found * Add translations * Added changes for orgGeo (#1093) * Refactor: Move actions-hub and preview-site folder under power-pages (#1092) * Refactor: Move actions-hub and preview-site folder under power-pages * Remove unwanted file * Refactor * Add PPAPI to known words * Disable actions hub by default * Web Extension: Remove dependency on website preview URL (#1091) * Web Extension: Remove dependency on website preview URL * Translations * Web Extension: Fix file opening for media files (#1094) Using `vscode.open` API to open the default file instead of `window.showTextDocument` because `showTextDocument` doesn't open binary files to it was failing to open non-text files. * Bump CLI version from 1.37.4 to 1.39.3 (#1095) * Fix environment icon for dark mode (#1097) * Fix environment icon for dark mode * Refactor * Fix test * fix screen reader issue in copilot chat (#1100) Co-authored-by: Sandeep Satheesh <[email protected]> * add focus ring (#1099) Co-authored-by: Sandeep Satheesh <[email protected]> * add release notes (#1101) Co-authored-by: Sandeep Satheesh <[email protected]> * Site Preview: Initialize after ECS fetch (#1102) * Site Preview: Initialize after ECS fetch * Set context after loading website URL * Add source attribute handling and telemetry for invalid attributes in web extension (#1105) * Add source attribute handling and telemetry for invalid attributes in web extension * Refactor source attribute handling in processDataAndCreateFile function --------- Co-authored-by: amitjoshi <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: amitjoshi438 <[email protected]> Co-authored-by: amitjoshi <[email protected]> Co-authored-by: Ashwani Kumar <[email protected]> Co-authored-by: Ashwani Kumar <[email protected]> Co-authored-by: tyaginidhi <[email protected]> Co-authored-by: Priyanshu Agrawal <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sandeep Satheesh <[email protected]> Co-authored-by: Priyanshu Agrawal <[email protected]> Co-authored-by: BidishaMS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the accessibility of the feedback icons and adds keyboard event handling for better user interaction. The most important changes include adding ARIA labels and tabindex attributes to the feedback icons and implementing a new function to handle keyboard events.
Accessibility improvements:
src/common/copilot/assets/scripts/copilot.js: Addedtabindex="0"andaria-labelattributes to the thumbs up and thumbs down SVG elements to make them accessible via keyboard navigation.Keyboard event handling:
src/common/copilot/assets/scripts/copilot.js: Added an event listener for thekeydownevent to handle keyboard interactions with the feedback icons.src/common/copilot/assets/scripts/copilot.js: Implemented thehandleFeedbackKeydownfunction to handle "Enter" and "Space" key presses for thumbs up and thumbs down interactions.